Parameterized graphql endpoint and caching #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidjgonzalez
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
@jihuang-adobe can you take a look at these changes.
- Changes the wknd-shared to be the default as afiak most people (outside Adobe SC) use wknd (and not RDA)
- Changed semantics of the Cache toggle, since what youre really doing is disabling the cache w/ its addition (it caches by default). This also helps communicate that disabling is the "outlier" case. I also added a number of comments to re-emphasize disabling cache should not be done on Production.
Co-authored-by: david g. <[email protected]>
Co-authored-by: david g. <[email protected]>
Co-authored-by: david g. <[email protected]>
Co-authored-by: david g. <[email protected]>
Co-authored-by: david g. <[email protected]>
Co-authored-by: david g. <[email protected]>
Co-authored-by: david g. <[email protected]>
Co-authored-by: david g. <[email protected]>
Co-authored-by: david g. <[email protected]>
Co-authored-by: david g. <[email protected]>
davidjgonzalez
approved these changes
Dec 7, 2023
|
OMG, LGTM is good for me. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of hardcoding it in usePersistedQueries.js, graphql endpoint namespace is now part of .env.
Graphql caching can be configured in .env.
Related Issue
#95
Motivation and Context
Both customers with AEM Guides WKND installed and Adobe internal with Reference Demo installed can use the code hosted on code sandbox, simply change the graphql endpoint namespace to enable the sample hosted app to pull content from their environment.
https://experienceleague.adobe.com/landing/experience-manager/headless/developer/code/basic-react-app.html?lang=en
How Has This Been Tested?
tested locally and tested on online hosted sandbox
https://codesandbox.io/p/sandbox/wknd-react-app-forked-gfrtlf
Screenshots (if appropriate):
Types of changes
Checklist: